i#5733, i#5734: Minor fixes in tests #5796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds -max_trace_size to api.rseq to avoid generating too much trace data, which may cause us to run out of disk space sometimes. The issue on varying run times (and therefore trace data) is not reproducing now on the Jenkins machine, but with this change, the trace size comes down to 512K from 130M+ which is better. Fixes an issue in the invariant checker that affects error reporting when there's no shard stream available. This came up in the tool.drcacheoff.rseq test. Issue: #5733, #5734
derekbruening
approved these changes
Dec 16, 2022
derekbruening
approved these changes
Dec 19, 2022
dolanzhao
pushed a commit
that referenced
this pull request
Jan 30, 2023
Adds -max_trace_size to api.rseq to avoid generating too much trace data, which may cause us to run out of disk space. The issue on varying run times (and therefore trace data) is not reproducing now on the Jenkins machine, but with this change, the trace size comes down to 512K from 130M+ which is better. Fixes an issue in the invariant checker that causes a SIGSEGV crash during error reporting when there's no shard stream available. This came up in the tool.drcacheoff.rseq test during the check_schedule_data checks that happen at the very end in print_results of the invariant checker, where we do not have the shard stream anymore. The invariant error itself is yet to be debugged (i#5734). For the missing shard stream, we now use a default stream with manually set ref ordinal. Issue: #5733, #5734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds -max_trace_size to api.rseq to avoid generating too much trace data,
which may cause us to run out of disk space. The issue on varying run times
(and therefore trace data) is not reproducing now on the Jenkins machine,
but with this change, the trace size comes down to 512K from 130M+ which
is better.
Fixes an issue in the invariant checker that causes a SIGSEGV crash during
error reporting when there's no shard stream available. This came up in the
tool.drcacheoff.rseq test during the
check_schedule_datachecks thathappen at the very end in
print_resultsof the invariant checker, wherewe do not have the shard stream anymore. The invariant error itself is yet
to be debugged (i#5734).
Issue: #5733, #5734