i#5538 memtrace seek, part 8: Add skip_thread_instructions() #5731
Conversation
Adds a new skip_instructions() reader iterator interface. It is a linear walk for every type of reader except a chunked zipfile walking a single thread. Adds a drcachesim command line option -skip_instrs which triggers the analyzer to skip from the start before passing anything to the tool. Refactors the reader_t++ to provide a process_input_entry to update state while skipping. Adds a unit test with an added trace file with a small chunk size. The test checks the view output for every skip value from 0 to over double the chunk size. Leaves several pieces for future work: + Recording the record count in each chunk so we have an accurate count after skipping. + Presenting global headers skipped over as memtrace_stream_t values that tools can query. + Reading the schedule files for serial skipping (or the planned cpu iterator and skipping). + Repeating the timestamp+cpu for non-zipfile skipping. Issue: #5538
|
I am not understanding how my code here caused these OSX format string warnings: I thought maybe they upgraded the OSX compiler, but your PR #5711 isn't hitting these, right? I tried to fix thinking the APPLE_ define that's in there was incorrectly requesting long long, but the warning claims the type is long long: but it's uint64_t and size_t for the two things being printed. Going ahead and asking for a review as maybe you can see what I'm missing, or maybe you did hit this in your PR's? |
I removed the dr_api.h from skip_unit_tests.cpp which was the cause as it turns out: it was only the include from that file that hit these. I'll leave the PRIx64 change as that seems an improvement. |
|
a64 run in the latest is #5493 |
…ents per review suggestions
|
arm failed on linux.signal0101 which is #5167 |
Adds a new skip_instructions() reader iterator interface. It is a linear walk for every type of reader except a chunked zipfile walking a single thread.
Adds a drcachesim command line option -skip_instrs which triggers the analyzer to skip from the start before passing anything to the tool.
Refactors the reader_t++ to provide a process_input_entry to update state while skipping.
Adds a unit test with an added trace file with a small chunk size. The test checks the view output for every skip value from 0 to over double the chunk size.
Leaves several pieces for future work:
Issue: #5538