i#38 attach: Make -skip_syscall the default #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes interrupting a blocking syscall on attach the default behavior. Removes the -skip_syscall drrun/drinject parameter. Adds a test by adding an optional blocking syscall to infloop. Issue: #38
…blocking in the suite
|
No idea why a64 attach is failing when it works on manual tests...investigating. |
|
Finally tracked down the reason for the failure: it is a fundamental bug on relocating DR: #5463. Will fix it first and then resume this. |
derekbruening
added a commit
that referenced
this pull request
Apr 14, 2022
Fixes errors that can lead to crashes in relocate_dynamorio, where its access to a function pointer and to the page size can both return garbage pre-relocation. We solve this with assembly to get the current PC, and just using a 4K minimum page size for the backward walk. Tested with the PR #5462 branch where the new client.attach_blocking test crashes without this fix on AArch64. Manually tested on arm as well. Fixes #5463
derekbruening
added a commit
that referenced
this pull request
Apr 15, 2022
Fixes errors that can lead to crashes in relocate_dynamorio, where its access to a function pointer and to the page size can both return garbage pre-relocation. We solve this with assembly to get the current PC, and just using a 4K minimum page size for the backward walk. Tested with the PR #5462 branch where the new client.attach_blocking test crashes without this fix on AArch64. Manually tested on arm as well. Fixes #5463
bete0
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes interrupting a blocking syscall on attach the default behavior.
Removes the -skip_syscall drrun/drinject parameter.
Adds a test by adding an optional blocking syscall to infloop.
Issue: #38