i#5458: Switch suspend signal to SIGFPE #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the signal that DR uses to suspend a thread from SIGUSR2, which is sometimes blocked by the app at attach time, to SIGFPE, which as a fatal normally-synchronous signal is less likely to be blocked. Manually tested on an attach to mysqld which failed with SIGUSR2 but succeeds now. Fixes #5458
|
Unfortunately it's looking like QEMU does not handle DR sending SIGFPE via SYS_kill. |
… SIGFPE under QEMU
bete0
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the signal that DR uses to suspend a thread from SIGUSR2,
which is sometimes blocked by the app at attach time, to SIGFPE, which
as a fatal normally-synchronous signal is less likely to be blocked.
Manually tested on an attach to mysqld which failed with SIGUSR2 but
succeeds now.
Fixes #5458