i#5121: Add test for insertion phase respill after app2app restore #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new drreg test to show another multi-phase use scenario. This demonstrates that the insertion phase respills the original app value to its slot after the app2app phase restores it. This results in overwriting the app2app meta value that was present in the insertion phase slot previously. This original app value is then restored by insertion phase before subsequent app read instrs. Issue: #5121
derekbruening
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new drreg test to show another multi-phase use scenario.
This demonstrates that the insertion phase updates the reg value
in its own slot after the app2app phase restores it to the original
app value before an app read. This results in overwriting the app2app
meta value that was present in the insertion phase's slot previously.
This original app value is then restored correctly by insertion phase
before subsequent app read instrs.
Instrumented basic block for the new test#38, after app2app and
insertion phase (each drreg op is annotated):
https://gist.github.com/abhinav92003/6a663cb19fda01838451bbe41b329bdc
Issue: #5121