i#731,i#3271: Keep IR cti+copied bits valid and re-relativized #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds rip-relative information tracking at IR levels 1-3 for instruction references on x86, extending the existing tracking for data references. Adds decode_sizeof_ex() and instr_get_rel_data_or_instr_target() to support rip-relative displacement and target handling. Changes decode_from_copy() to preserve raw bits for all instructions, eliminating problems where untracked encoding features are lost such as in #4017. Documents the changes and describes how to avoid the new behavior. Does just that for intra-sequence cti's in the rseq native code copy. Adds test cases to api.ir. Implementing the same thing for AArchXX is left unimplemented, tracked by i#4016. Issue: #731, #3271, #3339, #4016, #4017 Fixes #731 Fixes #3271 Fixes #4017
|
(Making sure the CI is green before requesting review since this has potential to break things.) |
Expand comment on instr-vs-data.
|
All issues resolved. PTAL. See #4017 (comment) for logic behind tackling the full #731. |
Carrotman42
requested changes
Jan 16, 2020
|
PTAL. Sorry, I pre-emptively merged in upstream to deal w/ a conflict, so the "changes since last review" button may not be a good view: but selecting just the final commit from the commit selection dropdown on the diff page will show the review changes. |
Carrotman42
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rip-relative information tracking at IR levels 1-3 for
instruction references on x86, extending the existing tracking for
data references.
Adds decode_sizeof_ex() and instr_get_rel_data_or_instr_target() to
support rip-relative displacement and target handling.
Changes decode_from_copy() to preserve raw bits for all instructions,
eliminating problems where untracked encoding features are lost such
as in #4017.
Documents the changes and describes how to avoid the new behavior.
Does just that for intra-sequence cti's in the rseq native code copy.
Adds test cases to api.ir.
Implementing the same thing for AArchXX is left unimplemented, tracked
by i#4016.
Issue: #731, #3271, #3339, #4016, #4017
Fixes #731
Fixes #3271
Fixes #4017