Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2626 AArch64 enc: Add FP data-processing instrs (1 source) #3061

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Jun 20, 2018

This patch adds support for the instructions in the Armv8-a
'Floating-point data-processing' encoding groups with 1 source.

Issue #2626

This patch adds support for the instructions in the Armv8-a
'Floating-point data-processing' encoding groups with 1 source.

Issue #2626

Change-Id: I5b4538490a161fd550396627db3f0478e95b1841
@fhahn fhahn requested review from derekbruening and egrimley June 20, 2018 19:32
@derekbruening
Copy link
Contributor

I'm on vacation and traveling for the next few days -- I will have some internet access but it may be best to ask a different reviewer in case I don't get to this until Monday

@fhahn
Copy link
Contributor Author

fhahn commented Jun 20, 2018

Enjoy your vacation :) I'll check with either Edmund or Assad.

cc @andreipoe

@fhahn fhahn requested a review from AssadHashmi June 20, 2018 20:05
@fhahn
Copy link
Contributor Author

fhahn commented Jun 25, 2018

Travis failure is #2921

Copy link
Contributor

@egrimley egrimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhahn
Copy link
Contributor Author

fhahn commented Jun 25, 2018

Thanks Edmund!

@fhahn fhahn merged commit c3f6241 into master Jun 25, 2018
@fhahn fhahn deleted the i2626-floatdp1 branch June 25, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants