Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3023: add new-thread barrier during attach #3024

Merged
merged 2 commits into from
May 23, 2018

Conversation

derekbruening
Copy link
Contributor

Adds a barrier to taken-over threads creating new threads until attach
is fully finished. This avoids problems keeping up with an app that
is creating threads while we try to attach.

Fixes #3023

Adds a barrier to taken-over threads creating new threads until attach
is fully finished.  This avoids problems keeping up with an app that
is creating threads while we try to attach.

Fixes #3023
@derekbruening
Copy link
Contributor Author

run aarch64 tests

@derekbruening
Copy link
Contributor Author

We have what I believe are flaky tests -- re-running (unclear how to re-run Jenkins build directly so did a new commit...will have to live w/ re-running Appveyor):

debug-internal-64: 163 tests passed, **** 2 tests failed, of which 1 were flaky: ****
	code_api|linux.signal1011 =>  Application /data/jenkins_root/workspace/DynamoRIO-AArch64-Precommit/build/build_debug-internal-64/suite/tests/bin/linux.signal1011 (13008).  Internal Error: DynamoRIO debug check failure: /data/jenkins_root/workspace/DynamoRIO-AArch64-Precommit/core/arch/mangle_shared.c:765 skip_pc != NULL  cti_pc != NULL 
debug-internal-64: 289 tests passed, **** 2 tests failed, of which 1 were flaky, but ignoring 0 for i: ****
	code_api|tool.drcacheoff.burst_threads 
	code_api|api.static_sideline_FLAKY 

@derekbruening derekbruening merged commit f1d0420 into master May 23, 2018
@derekbruening
Copy link
Contributor Author

I filed #3025 on the signal.1011 failure as it seems new (but did not reproduce)

@derekbruening derekbruening deleted the i3023-attach-barrier branch May 23, 2018 22:22
fhahn pushed a commit that referenced this pull request Jun 18, 2018
Adds a barrier to taken-over threads creating new threads until attach
is fully finished.  This avoids problems keeping up with an app that
is creating threads while we try to attach.

Fixes #3023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant