Skip to content

Commit

Permalink
i#4532 extra opnds: Remove extra opnd handling in mangling (#5253)
Browse files Browse the repository at this point in the history
Removes a no-longer-needed extra check to identify a load exclusive
pair, now that the superfluous immediate integer operands are removed.

Tested on the client.ldstex test which should fail if we incorrectly
identify a pair.

Issue: #4532
  • Loading branch information
derekbruening authored Dec 16, 2021
1 parent 552a403 commit b56a61f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions core/arch/aarchxx/mangle.c
Original file line number Diff line number Diff line change
Expand Up @@ -3468,8 +3468,7 @@ mangle_exclusive_store(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
instr_t *next_instr)
{
ASSERT(instr_is_exclusive_store(instr));
/* XXX i#4532: There is a bogus int opnd we have to account for here. */
bool is_pair = instr_num_srcs(instr) > 1 && opnd_is_reg(instr_get_src(instr, 1));
bool is_pair = instr_num_srcs(instr) > 1;
#ifdef ARM
/* TODO i#1698: Preserve ARM predication and add tests. For now we bail. */
if (instr_is_predicated(instr)) {
Expand Down

0 comments on commit b56a61f

Please sign in to comment.