Skip to content

Commit

Permalink
i#6624: Warn instead of ASSERT for unexpected SP value. (#7076)
Browse files Browse the repository at this point in the history
Downgrades an assert in vmareas.c:is_on_stack() on a bad stack pointer
to a warning, as this is just a surprising application state and nothing
DR can't handle.

Fixes #6624
  • Loading branch information
egrimley-arm authored Nov 12, 2024
1 parent 32782c1 commit 871e769
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion core/vmareas.c
Original file line number Diff line number Diff line change
Expand Up @@ -3910,7 +3910,8 @@ is_on_stack(dcontext_t *dcontext, app_pc pc, vm_area_t *area)
ok = get_memory_info(esp, &esp_base, &size, NULL);
if (!ok) {
/* This can happen with dr_prepopulate_cache(). */
ASSERT(!dynamo_started);
if (dynamo_started)
SYSLOG_INTERNAL_WARNING("Stack pointer has unexpected value");
return false;
}
LOG(THREAD, LOG_VMAREAS, 3,
Expand Down

0 comments on commit 871e769

Please sign in to comment.