Skip to content

Commit

Permalink
Rename ciba custom properties on response and add more xml doc
Browse files Browse the repository at this point in the history
  • Loading branch information
josephdecock committed Jan 15, 2024
1 parent 56b93dc commit c8eca05
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ await context.Response.WriteJsonAsync(new SuccessResultDto
expires_in = result.Response.ExpiresIn,
interval = result.Response.Interval,

Properties = result.Response.Properties
Properties = result.Response.Custom
});
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/IdentityServer/Models/BackchannelUserLoginRequest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ public class BackchannelUserLoginRequest
public ResourceValidationResult ValidatedResources { get; set; } = default!;

/// <summary>
/// Gets or sets a dictionary of custom properties that can pass additional
/// state to the notification process.
/// Gets or sets a dictionary of custom properties associated with this
/// request. These properties by default are copied from the validated
/// custom request parameters.
/// </summary>
public Dictionary<string, object> Properties { get; set; } = new();
}
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ public BackchannelAuthenticationResponse(string error, string errorDescription =
public int Interval { get; set; }

/// <summary>
/// Gets or sets a dictionary of custom properties that can pass additional
/// state in the response to the client application.
/// Gets or sets a dictionary of custom properties that will be included in
/// the response to the client. This dictionary is intended to be used to
/// implement extensions to CIBA that defines additional response
/// parameters.
/// </summary>
public Dictionary<string, object> Properties { get; set; } = new();
public Dictionary<string, object> Custom { get; set; } = new();
}
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ public class ValidatedBackchannelAuthenticationRequest : ValidatedRequest
public string? RequestObject { get; set; }

/// <summary>
/// Gets or sets a dictionary of custom properties that can pass
/// additional state to the back channel authentication process.
/// Gets or sets a dictionary of validated custom request parameters. Custom
/// request parameters should be validated and added to this collection in
/// an <see cref="ICustomBackchannelAuthenticationValidator"/>. These
/// properties are persisted to the store and made available in the
/// backchannel authentication UI and notification services.
/// </summary>
public Dictionary<string, object> Properties { get; set; } = new();
}
4 changes: 3 additions & 1 deletion src/Storage/Models/BackChannelAuthenticationRequest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ public class BackChannelAuthenticationRequest
public string? Description { get; set; }

/// <summary>
/// Gets or sets a dictionary of custom properties associated with this instance.
/// Gets or sets a dictionary of custom properties associated with this
/// request. These properties by default are copied from the validated
/// custom request parameters.
/// </summary>
public Dictionary<string, object> Properties { get; set; } = new();
}

0 comments on commit c8eca05

Please sign in to comment.