Update some of dependencies and compile fix. #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
takahirom
reviewed
Jul 11, 2018
| @@ -94,6 +94,7 @@ object Depends { | |||
| object Groupie { | |||
| val core = "com.xwray:groupie:${Versions.groupie}" | |||
| val binding = "com.xwray:groupie-databinding:${Versions.groupie}" | |||
| val kotlinExtensions = "com.xwray:groupie-kotlin-android-extensions:${Versions.groupie}" | |||
There was a problem hiding this comment.
Probably you don't use this dependency 👀
takahirom
reviewed
Jul 11, 2018
| } | ||
| dependencies { | ||
| classpath(kotlin("gradle-plugin", Versions.kotlin)) | ||
| } | ||
| } | ||
|
|
||
| allprojects { |
There was a problem hiding this comment.
I think allprojects is not needed. 📁
What do you think?
repositories {
google()
jcenter()
}
takahirom
reviewed
Jul 11, 2018
| @@ -13,7 +13,7 @@ data class StaffItem( | |||
| ) : BindableItem<ItemStaffBinding>(staff.name.hashCode().toLong()) { | |||
|
|
|||
| override fun createViewHolder(itemView: View): ViewHolder<ItemStaffBinding> { | |||
| return ViewHolder(DataBindingUtil.bind(itemView)) | |||
| return ViewHolder(DataBindingUtil.bind(itemView)!!) | |||
There was a problem hiding this comment.
Probably we can use HogeHogeBinding.inflate(xxx) method. 👀
But If you don't have time, I think that is fine as it is.
|
Thank you for resolving problems !! 👍 That's cool 🆒 |
panpanini
reviewed
Jul 11, 2018
| @@ -219,7 +219,8 @@ dependencies { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenCentral() | |||
| jcenter() | |||
There was a problem hiding this comment.
please make sure google() is before jcenter()
| @@ -1,4 +1,5 @@ | |||
| import org.gradle.api.JavaVersion.VERSION_1_7 | |||
There was a problem hiding this comment.
it looks like this import is unused 👀
| @@ -0,0 +1 @@ | |||
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
|
Probably this is occurred by Kotlin DSL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot