Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TransitionListener #608

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Simplify TransitionListener #608

merged 2 commits into from
Feb 5, 2018

Conversation

panpanini
Copy link
Contributor

Issue

Overview (Required)

  • Shorten TransitionListener callsite code by separating interface into open class
    (I thought it would have more impact, but only one place is calling TransitionListener anyway 😭 )
  • Save 18 lines in SpeakerDetailFragment!

@panpanini
Create SimpleTransitionListener open class
3ad9cf0 
This should make TransitionListeners easier to use, because we only have
to implement the methods we care about
@panpanini
Use SimpleTransitionListener in SpeakerDetailFragment
bc3484a
@takahirom
Copy link
Member

LGTM 👍

@takahirom takahirom merged commit b256525 into master Feb 5, 2018
@takahirom takahirom deleted the panpanini/simplify_transition_listener branch February 5, 2018 09:27
@takahirom takahirom added this to the 1.1.0(〜02/05) milestone Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0(〜02/05)
Development

Successfully merging this pull request may close these issues.
3 participants
@panpanini @takahirom @KeithYokoma