-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LG TVs pre 2012 (can't get session id) #5
base: master
Are you sure you want to change the base?
Conversation
Fix for LG TVs pre 2012. Without it cant get the session id
I've had a look at this - and as this logic originates from the prior to this fork - I wanted to see if I can verify if this logic was always incorrect. From the other code I've seen that does looks to be the case. For my understanding, after you made this change can you confirm if you are also able to get a valid response from the Unfortunately I have a 2012 TV, so I cannot verify any pre-2012 functionality myself. |
Before I switched from wokar/pylgnetcast, HA depended on v0.2.0. HDCP support was added in v0.3.0 (5ad0e36). I think we can accept this and in case of problems we will roll back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding, after you made this change can you confirm if you are also able to get a valid response from the get_volume function as this change will also affect that function as well and whilst it seems this PR seems to suggest the HDCP support never worked properly (as authentication didn't work) it be good to ensure we ensure all the features work as expected.
After confirmation we can merge.
I will have a look.
|
Fix for LG TVs pre 2012.
Without it cant get the session id