Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bernard's consent review #10

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

martinthomson
Copy link

I've made quite few changes based on Bernard's feedback. The following changes are substantive in some sense:

  • Consent is maintained now by receiving a valid response. Previously, it was receiving a response to one of the checks that were initiated in the 30s window. This change makes it more robust.
  • Requests are abandoned when RTT (+delta) expires or when consent is lost. Requests aren't abandoned by receiving a response to a later request (the unlikely out of order request). This means that there is another timer that runs, in theory (clever implementers will learn that this timer doesn't need to be an actual timer).

Note: Please don't merge this until we conclude the list discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant