Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Updated, Docker Compose Improved #60

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

GitXpresso
Copy link

@GitXpresso GitXpresso commented Nov 9, 2024

I mostly updated the mark down the docker compose file got updated too. Looking back at my commits, I didn't check twice before I describe what I changed in the files.

Docker Compose file will be updated so you can update tor and won't disconnect after you click update and you can save your progress/data, the readme have a tutorial on how to setup the docker compose file
Fixed typo 1
Add a container_name to the docker compose file so you can start, stop and rm the container, You can update tor without disconnecting and having to update tor again in a continuous loop and progress can be saved
You can copy and paste the compose script from the readme.md
Add yaml next ``` under the docker compose script
Grammar check 1
fixed grammar 2
Add anchor link 1
2 new anchor links
Add anchor links, error need to be fixed
Anchor link Typo 2
Anchor link "Docker Compose Script" typo
Add others as an anchor link
Update anchor links
Fixed Error with anchor links drop down
Add image under the heading aka title "tor"
Add my user account link on the very bottom of this page.
@GitXpresso
Copy link
Author

Pull request, readme.md got updated

Docker installation tutorial part 1
Docker installation part 2
And finally docker installation part 4
Add docker installation guide as an anchor link.
Updated header aka title on line 116
Updated Anchor Link on line 12
@GitXpresso GitXpresso changed the title Check out pull request! Readme Updated, Docker Compose Improved Nov 9, 2024
Add tor project shield.io badge on line 6
Replace "&" with "And" on line 146
Fixed typo
Typo on line 104
Add "No" in front "VNC" on line 144
Grammar fix
bash next to ```
Grammar fix
@davidnewcomb
Copy link
Collaborator

  1. There is no need to include a copy of docker-compose.yml in the README file. It's just a duplication that would need to be updated. Please remove that section.
  2. "To verify that you docker put the following command below" - ??
  3. Remove "Github user who updated this markdown:" heading and section - no personal accreditations.
  4. Adjust table of contents accordingly.
  5. Change restart: unless-stopped back to restart: always - no data must be left on the filesystem when you are not using it. The current version of Firefox allows you to update the browser without killing the container. If you would like a permanant update, then you must rebuild it. The rebuild will pick up the latest OS updates as well.
  6. Revert "Provides direct access to the NoVNC server" back to "Provides direct access to the VNC server" - it is a VNC server. NoVNC is a client.

Dockerfile Outdated Show resolved Hide resolved
Recent commit changes reverted
Copy link
Author

@GitXpresso GitXpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back to it's original content

Copy link
Author

@GitXpresso GitXpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change unless-stopped to always and added a note

Copy link
Author

@GitXpresso GitXpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidnewcomb can you review my changes to the readme

@GitXpresso
Copy link
Author

GitXpresso commented Dec 26, 2024

Everything's done just let me know if I need to do some tweaks/changes to the readme and compose.yml

docker compose down
```
or you can do this
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the bash syntax highlighting here for consistency

# How to install Docker

### if you don't have curl then just do this
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the bash syntax highlighting here for consistency

```

### install docker using curl
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the bash syntax highlighting here for consistency


* shm_size might need to be set to 2GB or more if you experience crashes
<!-- nonthing was deleted here 🙄 -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this unnecessary comment

@@ -0,0 +1,50 @@
# /repositories/home:/hawkeye116477:/waterfox/xUbuntu_24.10 - openSUSE Download
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR, it is not relevant to this project


docker run -d -p 5800:5800 domistyle/tor-browser
docker run -d -p 5800:5800 --r estart always --name tor domistyle/tor-browser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in this command: --r estart should be --restart (extra space after the r should be removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants