-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme Updated, Docker Compose Improved #60
base: master
Are you sure you want to change the base?
Conversation
Docker Compose file will be updated so you can update tor and won't disconnect after you click update and you can save your progress/data, the readme have a tutorial on how to setup the docker compose file
Fixed typo 1
Add a container_name to the docker compose file so you can start, stop and rm the container, You can update tor without disconnecting and having to update tor again in a continuous loop and progress can be saved
You can copy and paste the compose script from the readme.md
Add yaml next ``` under the docker compose script
Grammar check 1
fixed grammar 2
Add anchor link 1
2 new anchor links
Add anchor links, error need to be fixed
Anchor link Typo 2
Anchor link "Docker Compose Script" typo
Add others as an anchor link
Update anchor links
Typo
Fixed Error with anchor links drop down
Add image under the heading aka title "tor"
Add my user account link on the very bottom of this page.
Pull request, readme.md got updated |
Docker installation tutorial part 1
Docker installation part 2
And finally docker installation part 4
Add docker installation guide as an anchor link.
Updated header aka title on line 116
Updated Anchor Link on line 12
Add tor project shield.io badge on line 6
Replace "&" with "And" on line 146
Fixed typo
Typo on line 104
Add "No" in front "VNC" on line 144
Grammar fix
bash next to ```
Grammar fix
|
Recent commit changes reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed back to it's original content
Readme Updated how @davidnewcomb wants it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change unless-stopped to always and added a note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidnewcomb can you review my changes to the readme
Everything's done just let me know if I need to do some tweaks/changes to the readme and compose.yml |
docker compose down | ||
``` | ||
or you can do this | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the bash syntax highlighting here for consistency
# How to install Docker | ||
|
||
### if you don't have curl then just do this | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the bash syntax highlighting here for consistency
``` | ||
|
||
### install docker using curl | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the bash syntax highlighting here for consistency
|
||
* shm_size might need to be set to 2GB or more if you experience crashes | ||
<!-- nonthing was deleted here 🙄 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this unnecessary comment
@@ -0,0 +1,50 @@ | |||
# /repositories/home:/hawkeye116477:/waterfox/xUbuntu_24.10 - openSUSE Download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file from the PR, it is not relevant to this project
|
||
docker run -d -p 5800:5800 domistyle/tor-browser | ||
docker run -d -p 5800:5800 --r estart always --name tor domistyle/tor-browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in this command: --r estart
should be --restart
(extra space after the r
should be removed)
I mostly updated the mark down the docker compose file got updated too. Looking back at my commits, I didn't check twice before I describe what I changed in the files.