Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arm64 version #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added arm64 version #64

wants to merge 2 commits into from

Conversation

dawidkulas
Copy link

@dawidkulas dawidkulas commented Oct 10, 2023

This is an Arm64 version for usage with Raspberry Pi or any other arm64 based devices.
I have tested VNC on Raspberry Pi 4 Model B with 4 GB of RAM and it worked fine.
Mounting ISO and screenshots haven't been tested.

Closes #4

@FoxxMD
Copy link

FoxxMD commented Oct 11, 2023

This can also be done without needing to specify specific architectures. Replacing the prerequisite package lines and wget for the specific debs with this:

apt-get install -y wget software-properties-common libx11-dev gcc xdotool gnupg ca-certificates curl && \
    curl -s https://repos.azul.com/azul-repo.key | gpg --dearmor -o /usr/share/keyrings/azul.gpg && \
    echo "deb [signed-by=/usr/share/keyrings/azul.gpg] https://repos.azul.com/zulu/deb stable main" | tee /etc/apt/sources.list.d/zulu.list && \
    apt-get update && \
    apt-get install zulu8-jre -y

(remove DOCKER_IMAGE_PLATFORM=arm64 as well)

I'm doing this in my fork and publishing working cross platform images with buildx

@dawidkulas
Copy link
Author

@FoxxMD Thank you very much for the advice! I added the repository as described on Azul website, made that additional dependencies are removed when not needed and also remove wget from being downloaded as it is not needed anymore.

And as you said, I removed DOCKER_IMAGE_PLATFORM=arm64 to make the build truly cross-platform.

@dawidkulas dawidkulas reopened this Oct 13, 2023
@dawidkulas
Copy link
Author

dawidkulas commented Oct 13, 2023

I am very sorry, I made a mistake of removing wget, and then I realised that it is required. It is now fixed.

@FoxxMD
Copy link

FoxxMD commented Oct 13, 2023

Additional improvement that would be beneficial for all images @DomiStyle ...

In this commit/PR #49 java.security was removed in order to "un"disable TLSv1.1 but it also made the fix architecture specific:

RUN rm /usr/lib/jvm/zulu-7-amd64/jre/lib/security/java.security

This can be achieved without architecture specific steps by overriding java.security with a new file in the java exec arg:

  1. Remove RUN rm /usr/lib/jvm/zulu-7-**amd64**/jre/lib/security/java.security
  2. create a java.security file that overrides the affected settings
  3. In dockerfile COPY java.security /java.security
  4. In startapp.sh add the java arg -Djava.security.properties="/java.security"

EDIT: If you need assistance with buildx for cross-platform docker images lmw. can be done with github actions or manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ARM version
2 participants