Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datepicker closing invoked by modal component #6501

Open
wants to merge 2 commits into
base: v1-dev
Choose a base branch
from

Conversation

k2s
Copy link

@k2s k2s commented Jan 10, 2020

Proposed changes

Datepicker component is shown inside Modal component. Datepicker close method asks Modal component to close, but Modal doesn't informDatepicker that is is closed/hidden.

Main issue is with ESC keypress that is handled by Modal, but also programmatical closing of the Modal element will not correctly handle Datepicker closing.

Problems that is this causing:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant