Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expandable FAB] Introduce Expandable FAB Component on Details Screen #75

Merged
merged 8 commits into from
Oct 13, 2024

Conversation

Divinelink
Copy link
Owner

@Divinelink Divinelink commented Oct 13, 2024

This pull request introduces a new component: an expandable FAB, similar to the one in Google Calendar. When the FAB is clicked, the background is dimmed, and the main actions are displayed with a staggered animation. Additionally, the FAB is now responsive to the Snackbar, automatically animating above it when the Snackbar is shown.

The primary motivation for this is to make the main actions clearer and to enhance the significance of the Jellyseerr's Request action, but it'll also enable us to add more core actions in the future: i.e Add to list etc..

Showcase

Screen.Recording.2024-10-13.at.9.04.07.PM.mov

@Divinelink Divinelink self-assigned this Oct 13, 2024
@Divinelink Divinelink added jellyseerr enhancement New feature or request labels Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 89.55823% with 26 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (227e43c) to head (f79a15b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...inelink/feature/details/media/ui/DetailsContent.kt 66.66% 5 Missing and 3 partials ⚠️
...ts/expandablefab/ExpandableFloatingActionButton.kt 94.73% 3 Missing and 3 partials ⚠️
...elink/feature/details/media/ui/DetailsViewModel.kt 0.00% 3 Missing and 1 partial ⚠️
...re/details/media/usecase/GetMediaDetailsUseCase.kt 62.50% 2 Missing and 1 partial ⚠️
...ink/feature/details/media/ui/MediaDetailsResult.kt 0.00% 2 Missing ⚠️
...kotlin/com/divinelink/core/commons/ErrorHandler.kt 66.66% 1 Missing ⚠️
...e/ui/snackbar/controller/SnackbarControllerImpl.kt 0.00% 0 Missing and 1 partial ⚠️
.../media/ui/DetailsExpandableFloatingActionButton.kt 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   77.48%   77.72%   +0.24%     
==========================================
  Files         357      362       +5     
  Lines        8354     8521     +167     
  Branches      791      802      +11     
==========================================
+ Hits         6473     6623     +150     
- Misses       1581     1591      +10     
- Partials      300      307       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Divinelink Divinelink merged commit a3f9a52 into main Oct 13, 2024
4 checks passed
@Divinelink Divinelink deleted the feature/details-fab-actions branch October 13, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jellyseerr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant