Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show total user score and user's rating on details screen #38

Merged
merged 3 commits into from
May 5, 2024

Conversation

Divinelink
Copy link
Owner

In this pull request we enhanced the details screen to show the total user score as well as the current's account rating.

Additionally, we did some redesign in the home screen media card regarding the user score. We wanted to give a similar look and feel to the original TMDB rating.

Details Screen

image

Media Card

image

@Divinelink Divinelink self-assigned this May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 75.97173% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 58.14%. Comparing base (100a6e0) to head (a3dd7f8).
Report is 1 commits behind head on main.

Files Patch % Lines
...s/movierama/ui/components/media/MediaRatingItem.kt 52.38% 25 Missing and 5 partials ⚠️
...m/andreolas/movierama/details/ui/DetailsContent.kt 78.66% 6 Missing and 10 partials ⚠️
...andreolas/movierama/details/ui/DetailsViewState.kt 52.94% 7 Missing and 1 partial ⚠️
...m/andreolas/movierama/home/ui/PopularMoviesList.kt 0.00% 4 Missing ⚠️
...main/java/com/andreolas/movierama/ui/Extensions.kt 20.00% 1 Missing and 3 partials ⚠️
...es/dto/account/states/RateResponseApiSerializer.kt 81.25% 1 Missing and 2 partials ⚠️
...andreolas/movierama/details/ui/DetailsViewModel.kt 89.47% 0 Missing and 2 partials ⚠️
...com/andreolas/movierama/ui/components/MovieItem.kt 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   56.40%   58.14%   +1.74%     
==========================================
  Files         140      150      +10     
  Lines        3537     3739     +202     
  Branches      537      565      +28     
==========================================
+ Hits         1995     2174     +179     
- Misses       1277     1288      +11     
- Partials      265      277      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Divinelink Divinelink force-pushed the feature/user_rating branch 2 times, most recently from 565d0d5 to a3dd7f8 Compare May 5, 2024 17:41
@Divinelink Divinelink merged commit e4a1057 into main May 5, 2024
6 checks passed
@Divinelink Divinelink deleted the feature/user_rating branch May 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant