-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Introduce User Authentication #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to completely replace Settings DSL API with compose. This help us achieve single activity architecture, reduce development time and also remove a lot of unnecessary files.
Implement functionality to obtain and utilize a sessionId for valid requests with the TMDB account. This involves guiding the user through authentication on the official TMDB website to generate a request token. Upon user authentication and permission approval, the request token is exchanged for a sessionId through an API call. The sessionId is encrypted for enhanced security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request we introduced the authentication functionality by following the following API doc.
The authentication is based on the following 3 steps:
For security purposes, the session ID is the encrypted to the device. This session ID will be used on future API requests, that way, the user can rate movies, see their lists etc.
It's important to note that the application NEVER gets access to the users credentials.
The authentication process is done by redirecting the user to the official TMDB website and the permitting the application to read and write data on behalf of the app. That way, we ensure that the user never enter their credential on our app. 😇
Changes made
Additionally, we made the following changes: