Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Smart Gas Price #46

Merged
merged 2 commits into from
Sep 30, 2019
Merged

[FEATURE] Smart Gas Price #46

merged 2 commits into from
Sep 30, 2019

Conversation

eswarasai
Copy link
Contributor

Ref: #44 DigixGlobal/governance-ui-components#381

Description

Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

Current behaviour just had a slider for gas price without any advanced options to quickly select it.

Test Plan

  • Before firing up the dev env, please make sure you also have the governance-ui-components PR is linked with this one during setup
  • Once you have dev setup up and running, open the app and login using Import JSON option
  • After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
  • In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description

@mandres-digix
Copy link
Contributor

Thanks @eswarasai! I'll look through this later while Mike does the tests.

@mikej-digix can you QA this for all our wallets? json, MetaMask, ledger, and trezor. Thanks!

@eswarasai eswarasai mentioned this pull request Sep 18, 2019
Merged
@gitcoinbot gitcoinbot mentioned this pull request Sep 18, 2019
Open
@mikej-digix
Copy link
Contributor

iteration: 1
status: PASSED
environment: LOCAL

Test Condition:

  • users should be able to use the smart gas price using json, metamask, ledger and trezor when doing transaction for dao environment.
    image

@mikej-digix mikej-digix merged commit 75cf010 into DigixGlobal:develop Sep 30, 2019
mikej-digix pushed a commit to DigixGlobal/governance-ui-components that referenced this pull request Sep 30, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#381)
58eaef3 
Ref: DigixGlobal/governance-ui#44 DigixGlobal/governance-ui#46

Description
Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

Current behaviour just had a slider for gas price without any advanced options to quickly select it.

Test Plan
Once you have dev setup up and running, open the app and login using Import JSON option
After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
mikej-digix pushed a commit that referenced this pull request Sep 30, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#46)
700c9d0 
Ref: #44 DigixGlobal/governance-ui-components#381

Description
Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

Current behaviour just had a slider for gas price without any advanced options to quickly select it.

Test Plan
Before firing up the dev env, please make sure you also have the governance-ui-components PR is linked with this one during setup
Once you have dev setup up and running, open the app and login using Import JSON option
After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
mikej-digix pushed a commit to DigixGlobal/governance-ui-components that referenced this pull request Sep 30, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#381)
dc58131 
    Ref: DigixGlobal/governance-ui#44 DigixGlobal/governance-ui#46

    Description
    Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

    Current behaviour just had a slider for gas price without any advanced options to quickly select it.

    Test Plan
    Once you have dev setup up and running, open the app and login using Import JSON option
    After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
    In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
mikej-digix pushed a commit to DigixGlobal/governance-ui-components that referenced this pull request Sep 30, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#381)
676a171 
    Ref: DigixGlobal/governance-ui#44 DigixGlobal/governance-ui#46

    Description
    Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

    Current behaviour just had a slider for gas price without any advanced options to quickly select it.

    Test Plan
    Once you have dev setup up and running, open the app and login using Import JSON option
    After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
    In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
mikej-digix pushed a commit that referenced this pull request Sep 30, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#46)
21948bf 
Ref: #44 DigixGlobal/governance-ui-components#381

Description
Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

Current behaviour just had a slider for gas price without any advanced options to quickly select it.

Test Plan
Before firing up the dev env, please make sure you also have the governance-ui-components PR is linked with this one during setup
Once you have dev setup up and running, open the app and login using Import JSON option
After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
@eswarasai eswarasai deleted the feature/gas-price branch October 2, 2019 17:04
mikej-digix pushed a commit to DigixGlobal/governance-ui-components that referenced this pull request Oct 8, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#381)
3ef2a47 
    Ref: DigixGlobal/governance-ui#44 DigixGlobal/governance-ui#46

    Description
    Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

    Current behaviour just had a slider for gas price without any advanced options to quickly select it.

    Test Plan
    Once you have dev setup up and running, open the app and login using Import JSON option
    After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
    In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
mikej-digix added a commit that referenced this pull request Oct 8, 2019
@mikej-digix
BUILD: [FEATURE] Smart Gas Price (#46)
d21ec30
mikej-digix pushed a commit that referenced this pull request Oct 8, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#46)
6f60946 
Ref: #44 DigixGlobal/governance-ui-components#381

Description
Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

Current behaviour just had a slider for gas price without any advanced options to quickly select it.

Test Plan
Before firing up the dev env, please make sure you also have the governance-ui-components PR is linked with this one during setup
Once you have dev setup up and running, open the app and login using Import JSON option
After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
mikej-digix added a commit that referenced this pull request Oct 8, 2019
@mikej-digix
BUILD: [FEATURE] Smart Gas Price (#46)
a357f4c
mikej-digix pushed a commit to DigixGlobal/governance-ui-components that referenced this pull request Oct 8, 2019
@eswarasai @mikej-digix
[FEATURE] Smart Gas Price (#381)
e045719 
    Ref: DigixGlobal/governance-ui#44 DigixGlobal/governance-ui#46

    Description
    Added a Smart Gas Price component with Advanced options mode to be able to switch fast between the amount of gas price user would like to pay based on transaction times whose values are being fetched directly from ETHGasStation API.

    Current behaviour just had a slider for gas price without any advanced options to quickly select it.

    Test Plan
    Once you have dev setup up and running, open the app and login using Import JSON option
    After logging in, click on Lock DGD button on the Header and enter the amount you'd like to lock
    In the transaction details and signing screen, you should now see options to select the gas price similar to the design mentioned in the issue description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandres-digix mandres-digix mandres-digix approved these changes

@mikej-digix mikej-digix Awaiting requested review from mikej-digix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eswarasai @mandres-digix @mikej-digix