Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPGRADE WORKER TO LATEST RUBY V3.2.2 #234

Merged
merged 6 commits into from
Apr 15, 2024
Merged

UPGRADE WORKER TO LATEST RUBY V3.2.2 #234

merged 6 commits into from
Apr 15, 2024

Conversation

danielaboost
Copy link

@danielaboost danielaboost commented Apr 2, 2024 •
edited
Loading

  • Upgrading the ruby version for the worker to v3.2.2
  • Removing puma metrics as we don't use it and it has compatibility issues
  • Some Rubocop fixes with the Rubocop upgrade

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Code quality score

Nice work!! The code quality has improved for this PR! ✨ 🌈 🎉 🌟

Ruby file count Similarity score (flay) ABC complexity (flog) Code smells (reek) TOTALS
base 63 1.3 8.16 18.4 27.86
this branch 63 1.3 8.08 18.4 27.78
difference 0 0.0 -0.08 0.0 -0.08

tom-mcculloch
tom-mcculloch approved these changes Apr 4, 2024
View reviewed changes
Copy link

@tom-mcculloch tom-mcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 👏 👏 👏

chigginsboost
chigginsboost approved these changes Apr 4, 2024
View reviewed changes
Copy link

@chigginsboost chigginsboost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🏅

@tom-mcculloch
Copy link

Still looks fab!

@paul-mesnilgrente paul-mesnilgrente merged commit 2de7aae into main Apr 15, 2024
6 checks passed
@paul-mesnilgrente paul-mesnilgrente deleted the dl/ruby-upgrade-322 branch April 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-mcculloch tom-mcculloch tom-mcculloch approved these changes

@chigginsboost chigginsboost chigginsboost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielaboost @tom-mcculloch @chigginsboost @paul-mesnilgrente