Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gm/retry extractions #77

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Gm/retry extractions #77

merged 5 commits into from
Jul 26, 2024

Conversation

motizuki
Copy link
Contributor

@motizuki motizuki commented Jul 25, 2024 •
edited
Loading

Extraction process is retried when it fails.

  • Setup a default Retriable config:
Retriable.configure do |c|
  c.tries = 10
  c.base_interval = 3
  c.multiplier = 2
end
  • Retry the AbstractExtraction#extract when an exception occur

@github-actions GitHub Actions
Copy link

Code quality score

Uh oh! The code quality got worse for this PR! Better take a look!! 🚨

Ruby file count Similarity score (flay) ABC complexity (flog) Code smells (reek) TOTALS
base 90 6.12 5.36 17.15 28.63
this branch 90 6.12 5.36 17.2 28.68
difference 0 0.0 0.0 ⚠️ 0.05 0.05

@motizuki motizuki force-pushed the gm/retry-extractions branch from df2be24 to b80146f Compare July 25, 2024 03:59
hapiben
hapiben approved these changes Jul 25, 2024
View reviewed changes
spec/spec_helper.rb Outdated Show resolved Hide resolved
richardmatthewsdev
richardmatthewsdev approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@richardmatthewsdev richardmatthewsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@motizuki motizuki force-pushed the gm/retry-extractions branch from 6e9859c to b7aa408 Compare July 25, 2024 23:43
@motizuki
feat: Add ENV vars to control retriable gem
7255a5f 
- RETRIABLE_TRIES
- RETRIABLE_BASE_INTERVAL
- RETRIABLE_MULTIPLIER
@motizuki motizuki force-pushed the gm/retry-extractions branch from b7aa408 to 7255a5f Compare July 26, 2024 00:17
@motizuki motizuki merged commit a77545a into main Jul 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardmatthewsdev richardmatthewsdev richardmatthewsdev approved these changes

@hapiben hapiben hapiben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@motizuki @hapiben @richardmatthewsdev