Past jobs can still be viewed when an enrichment definition or harvest definition is removed #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 25, 2024 14:56
Code quality scoreLovely, the code quality is unchanged for this PR 😊
|
danielaboost
changed the title
motizuki
approved these changes
Jul 25, 2024
eoin-boost
reviewed
Jul 25, 2024
| @@ -7,7 +7,7 @@ class HarvestJob < ApplicationRecord | |||
| belongs_to :pipeline_job | |||
| belongs_to :harvest_definition | |||
| belongs_to :extraction_job, optional: true | |||
| has_one :harvest_report, dependent: :destroy | |||
| has_one :harvest_report, dependent: nil | |||
There was a problem hiding this comment.
fyi standard would agree with you it seems 😄
https://github.com/standardrb/standard-rails/blob/main/config/base.yml#L181
eoin-boost
reviewed
Jul 25, 2024
eoin-boost
reviewed
Jul 25, 2024
eoin-boost
reviewed
Jul 25, 2024
eoin-boost
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports were dependent on their enrichment definitions and harvest definitions, and they were being destroyed if the definition was deleted. This meant the reports tab was breaking as the report no longer existed.
We're fixed this by making reports an independent object, which copies the pipeline name that it belongs to (the only piece of data that was missing once the definition had been deleted)