Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW SJ PP HARVEST: As Dan, I want new SJ to be able to harvest from the PapersPast open data set, so that we can start experimenting with how to feasibly bring the whole collection into our system #70

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

paul-mesnilgrente
Copy link
Contributor

NEW SJ PP HARVEST: As Dan, I want new SJ to be able to harvest from the PapersPast open data set, so that we can start experimenting with how to feasibly bring the whole collection into our system

STORY

Acceptance Criteria

  • New SJ can harvest a sample of the PP open data (check in with PO if this proves difficult or not appropriate)
  • Overall data transfer is done efficiently
  • long term architecture of solution is considered

@paul-mesnilgrente paul-mesnilgrente force-pushed the pm/pp branch 2 times, most recently from 5b90c01 to e061fdc Compare June 19, 2024 15:44
Copy link

github-actions bot commented Jun 19, 2024

Code quality score

Nice work!! The code quality has improved for this PR! ✨ 🌈 🎉 🌟

Ruby file count Similarity score (flay) ABC complexity (flog) Code smells (reek) TOTALS
base 88 6.12 5.36 17.2 28.68
this branch 90 6.12 5.36 17.15 28.63
difference 2 0.0 0.0 -0.05 -0.05

@paul-mesnilgrente paul-mesnilgrente force-pushed the pm/pp branch 2 times, most recently from 5ff2277 to 827a5c0 Compare June 19, 2024 20:50
@paul-mesnilgrente paul-mesnilgrente merged commit 01c59f3 into main Jul 15, 2024
8 checks passed
@paul-mesnilgrente paul-mesnilgrente deleted the pm/pp branch July 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants