Enrichment attributes are being saved to the wrong record #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of a fragment when the enrichment URL is full in the fragment
Allow the key and source id for an enrichment to be specified in an extraction definition.
DNZ Quarterly Updates
…e pages refer to the correct document The filesystem order cannot be relied on as different filesystems order files differently. We are essentially treating the file system as an array of pages and needing the index to be the same as the page number, so doing something like @documents[10] needs to give page the 10th page. Without sorting them this is not necessarily the case and you can get back a different page than what you are expecting.
danielaboost
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
All enrichment data is applied to the record that it is intended for.
Notes
During our investigation of the Gazette harvest we discovered that some records were having an incorrect administering agency or title being applied to them. We can verify this because the title / administering agency on the actual landing page of the record is different to what is being written to the record. This is similar to an issue that Tim Hannah has found with enrichments on DNZ.
This also includes some quality of life changes that have been added to PCO around how to specify enrichments.