EXTRACTION STOP CONDITIONS (Part II): As Dan, I want a way to define when an extraction should stop so that the harvest does not run forever #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with Extraction Definitions
richardmatthewsdev
changed the title
…ded content and work with the response.body
…on the Extraction App
…ough the Interface
motizuki
reviewed
Jan 9, 2024
|
|
||
| block.call(document) | ||
| rescue StandardError => e | ||
| e |
There was a problem hiding this comment.
do we need to do something with e?
There was a problem hiding this comment.
Not at the moment. We don't have any error reporting yet but once we do we will populate the report with errors :).
motizuki
approved these changes
Jan 9, 2024
paul-mesnilgrente
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Notes