-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMPROVE ENRICHMENT EXTRACTION INTERFACE: As Dan, I want the Enrichment Extraction interface updated, so that the workflow is intuitive and I can better customise my extraction #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create an Enrichment Extraction by a modal, following the same pattern as a harvest extraction.
richardmatthewsdev
changed the base branch from
main
to
rm/workflow-enhancements-1
October 16, 2023 00:29
Add settings modal to the Enrichment Extraction view.
Initial stab at getting the Enrichment to work with the request and parameters.
Improve the way we extract records from the API response to be used in the extraction. Remove the source_id and the test button as they can be inferred from the pipeline and dont need to be tested.
Scope the API record on the enrichment extraction preview modal to just one record.
Next and previous through Extraction Preview
Allow the user to next and previous through the Enrichment response
Fix issue where deleting an enrichment would mess up the following priorities.
Use the destination from the pipeline job if the enrichment is run as part of a pipeline.
Fix alignment of information in Enrichment Preview Modal. Fix width of slug value on query builder.
Make sure that the URL when quering for enrichments is valid.
Improve Active Parameter settings when interacting with the Parmeter List Panel Add Active Fields to the Transformation App.
Improve feedback when previewing the record selector on the Transformation Definition.
Base the fallback record selector on the format for more consistent results.
Fix failing specs
Cover error state for a evaluated parameter in tests.
Create transformation of appropriate kind when coming from the extraction preview
motizuki
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement!
lunmanlee
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Win win @richardmatthewsdev !! Thanks for including the video 💇♀️
The API record format will always be JSON in the preview window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Details
Risks
Notes
record['dc_identifier']
and needs a.first.to_s
. Or when Dan uses a symbol instead of a string."#{record['hello']}/iamcool/#{record['goodbye']}"
will likely not work. Also if the URL is justrecord['landing_url']
(without quotes or curly brackets) it will failNotes
Gus has said that we need the ability to enrich from an API source, this could be a POST request with some headers and slugs based on information in the record.
Harvest From PDF
enrichment_extraction_improvements.mov