Merge pull request #62 from DigitalNZ/ed/nil-position-fix

BUG: STORY ITEM NIL POSITION
DigitalNZ · Feb 3, 2022 · e60af84 · e60af84
2 parents e6aa01d + 33995cd
commit e60af84
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/supplejack/story_item_relation.rb b/lib/supplejack/story_item_relation.rb
@@ -54,9 +54,11 @@ def respond_to_missing?(_method, *_args, &_blocks)
     private
 
     def build_items(items)
-      @items = items.map do |hash|
-        Supplejack::StoryItem.new(hash.merge(story_id: story.id, api_key: story.api_key))
-      end.sort_by(&:position)
+      story_items = items.map do |item|
+        Supplejack::StoryItem.new(item.merge(story_id: story.id, api_key: story.api_key))
+      end
+
+      @items = story_items.sort_by { |i| i.position.to_i }
     end
   end
 end