Fix Dandelion Implementation & Dandelion Tests #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandelion Fixes Embargo More Dandelion Fixes Revert "More Dandelion Fixes" This reverts commit 394bc1f. Reapply "More Dandelion Fixes" This reverts commit 4a5e1fe. More Dandelion fixes Update digibyte.code-workspace More fixers Revert "More fixers" This reverts commit 334a770. Revert "More Fixes" This reverts commit afdcc7f. Fix Dandelion & Dandelion Tests
gto90
approved these changes
Dec 22, 2024
|
Congratulations @JaredTate this is such a monumental and amazingly timely PR. Thank you so much for your hard work and dedication in crushing this final bug show stopping 8.22. Merry Christmas and Happy Holidays!!! |
|
ACK |
ycagel
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
cACK. Thank you @JaredTate! Appreciate all your efforts in fixing Dandelion. This one has been tough for quite some time. Congrats!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooray! After a lot of trouble the past 2 years I believe we have fixed dandelion and now have it working with the python test passing correctly. It would be great to get some people to help test and verify dandelion tx routing is working correctly. But from everything I gather, and my own tests, reading logs this appears to have done the trick. This is last major milestone to a final 8.22 release.
Run the test after compiling with:
I booted the wallet and sent some transactions, and everything in the debug.log I could see looked good! Embargoes being set and working as they should.
All 215 functional tests are passing now. Everything in 8.22 is working as it should now. 🥳