wallet: Remove unused descriptor checkbox from wallet creation dialog #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the unused descriptor checkbox from the wallet creation dialog. This change cleans up the UI and resolves compiler errors due to missing the `descriptor_checkbox` member by removing an unused element, improving the user experience. References: - #213 - #227 - #239 (comment)
gto90
requested review from
SmartArray,
JaredTate,
ycagel and
digicontributer
|
I can confirm this fixes the compilation issues when compiling without bdb
Unfortunately if you try and test this build with an existing wallet containing any legacy wallets the wallet will crash right away. I think the root cause of this bug is indeed this commit: https://github.com/DigiByte-Core/digibyte/pull/227/files This could be the cause of some issues I am seeing with Descriptor Wallets like with 8.22 and the Bison Wallet DEX. I get some very odd descriptor wallet errors there. It's important any compiled version releases have both descriptor and legacy wallet support. ie:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the unused descriptor checkbox from the wallet creation dialog.
Changes
Justification and Reasoning
This change cleans up the UI by removing an unused element, improving the user experience, and resolving a compilation error due to the missing
descriptor_checkboxmember that was previously deprecated.References
Testing
Additional Notes
Please review the changes and provide feedback. Feel free to comment if any issues or further improvements are needed.