Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of simple lightweight event base class #606

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Oct 31, 2024

I was going to use this as part of implementing blSampleStatus updates however in the end have plumped for a slightly different solution*, however I think this may be of use for other things.

Therefore I present this as a draft PR for general comment/feedback and if people want to use it.

*which turned out not to work, so I may still use it

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (fa31d79) to head (1ff6b78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   80.04%   80.11%   +0.07%     
==========================================
  Files          97       98       +1     
  Lines        6814     6845      +31     
==========================================
+ Hits         5454     5484      +30     
- Misses       1360     1361       +1     
Components Coverage Δ
i24 SSX 60.20% <ø> (ø)
hyperion 96.77% <96.77%> (+<0.01%) ⬆️
other 94.95% <ø> (ø)

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this really needs discussion with the wider bluesky community about why this isn't a core feature of bluesky already. I'm concerned that by doing this we're diverging more from standard bluesky things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants