Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next 15 update #458

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Next 15 update #458

wants to merge 14 commits into from

Conversation

eric-burel
Copy link
Contributor

Done:

  • running Next.js 15 codemode
  • app starts
  • fixing SASS warnings
  • starting to remove dependencies to React Bootstrap
  • removed "dynamic" params for GET route handlers (now they are dynamic as a default)

To do to close the migration:

  • finalize getting rid of React Bootstrap, first because it's overkill for us and adds many dependencies, and then because it raises an issue with refs. The OverlayTrigger in particular is raising issues. React Bootstrap code is here.
  • Next.js 15 caching model has changed: no more Client Router means we might have gotten rid of the stale responses issues client-side ? But not sure if related. I need to check what happens to "fetch" calls in shared

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for stateofjs canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs/deploys/674a258ea1ee310008f710b1

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for stateofcss canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/stateofcss/deploys/674a258e9549c30008f042d4

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for devographics-graphiql-internal canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql-internal/deploys/674a258ebd4b22000831aba3

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for state-of-graphql canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/state-of-graphql/deploys/674a258eeb085c00085dc264

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for devographics-graphiql2 canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql2/deploys/674a258ea21216000824017f

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for css2023 failed.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/css2023/deploys/674a258e7c5e2a0008c920e1

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for stateofjs2022 canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs2022/deploys/674a258e3ba2750008303eb1

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for tokyodev2022 canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/tokyodev2022/deploys/674a258e85e03d00087bd4cd

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for graphiql-devographics canceled.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-devographics/deploys/674a258e4008e90008646e28

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for devographics-static failed.

Name Link
🔨 Latest commit eb18f75
🔍 Latest deploy log https://app.netlify.com/sites/devographics-static/deploys/674a258ea54a3f0008080532

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
charts ❌ Failed (Inspect) Nov 29, 2024 8:40pm
results-astro ❌ Failed (Inspect) Nov 29, 2024 8:40pm

@eric-burel eric-burel marked this pull request as ready for review November 29, 2024 18:22
@eric-burel
Copy link
Contributor Author

@SachaG so it does build but:

  • you'll want to double check if forms are ok (especially checkbox inputs, select inputs etc., and maybe styling overall)
  • you'll want to double check that response creation works
  • you'll want to double check "@devographics/types" usage: I've started using zod to define schemas and infer type from there, in order to avoid having unparsed user content in endpoints (like how we handled prefilled clientData was not right)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant