Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MoistureChangeEvent #2644

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Hydroxycobalamin
Copy link
Contributor

This PR adds the MoistureChangeEvent as farmland moisture level changes Denizen event with following contexts and switches:

Context

<context.location> returns the LocationTag of the farmland.
<context.material> returns the MaterialTag of the farmland.
<context.old_level> returns the ElementTag of the previous moisture level.
<context.new_level> returns the ElementTag of the new moisture level.

Switches

from:<level> to only process the event when the previous moisture level matches the input.
to:<level> to only process the event when the new moisture level matches the input.

//
// @Location true
//
// @Triggers when a farmland moisture level changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe farmland's? or farmland block's? also most events seem to have a . at the end

//
// @Context
// <context.location> returns the LocationTag of the farmland.
// <context.material> returns the MaterialTag of the farmland.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since events usually fire before the thing happens, I'd specify that this is the material after the change, or at least what the material would be after the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants