Fix test_version during release process and simplify versions in README.md #1938
+12
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the README.md we had version info like this:
This cuts it down to just this:
Where
tag
is of the form2024.10.0-128-ge09eeb5
if it is after tag v2024.10.0, otherwise just2024.10.0
The
test_version
just checks the form, because we bump the versions before doing a git tag, so they can be off by one version temporarily. I think that's simpler than introducing more difficult logic inset_version
to handle this.Fixes #1655