Merge branch 'static-dev' into static #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: solve memory leak in RewardsCalc (seems in few places we totally forgot about call `mpz_clear` to clear the memory allocated for each used variable).
If tests in other translation units leave pblocktree and pcoinsTip in an initialized state, free the memory and set it to nullptr.
This reverts commit daad2c273657233735a100e5011fcc2fd1a88b75.
Unlike ZCash, we still have libsnark included in both the build and dependency systems. Therefore, this commit should remove all the libsnark-related components from both systems. zcash/zcash@26a8f68
add NotaryChecker class and its instance
allow -ac_private for the ZOMBIE test chain
In the real KMD chain (not in the first blocks), block.nBits will always be greater than KOMODO_MINDIFF_NBITS. Therefore, the control will never enter this conditional statement. Also "fee stealing" is impossible, since we have notary proof tx (last tx in notary mined block).
For some reason, we were not allowed to have additional vouts in the coinbase transaction if their total was greater than 0.1 KMD. Therefore, a coinbase transaction with 2.8 KMD in vout[0] and 0.2 KMD in vout[1] was forbidden. Since this release, we are allowing such transactions. We are not using height activation here to keep the code simple; instead, we have just removed the restriction itself.
fix datacarrier related command-line args
Remove libsnark, libgmp, mini-gmp
error: integer value -1 is outside the valid range of values [0, 3] for this enumeration type - https://trac.macports.org/ticket/69103 - boostorg/numeric_conversion@50a1eae - KomodoPlatform/komodo@9363d9e
S8 preps: new pubkeys, KIP-0002, KIP-0003, etc.
The KIP0003 consensus rule was added in the `dev` branch as "logging only", i.e. as disabled. However, in the `patch-s8-prepare-hf-test` branch, which we used for testing on hfnet, it's already enabled (as seen in [this commit](KomodoPlatform/komodo@783fc1f)). For the release, we should enable this rule and make the logging optional using the hfnet category. - KomodoPlatform/komodo#626
Merge branch 'static-experimental' into static-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.