Remove libsnark, libgmp, mini-gmp #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: solve memory leak in RewardsCalc (seems in few places we totally forgot about call `mpz_clear` to clear the memory allocated for each used variable).
If tests in other translation units leave pblocktree and pcoinsTip in an initialized state, free the memory and set it to nullptr.
This reverts commit daad2c273657233735a100e5011fcc2fd1a88b75.
Unlike ZCash, we still have libsnark included in both the build and dependency systems. Therefore, this commit should remove all the libsnark-related components from both systems. zcash/zcash@26a8f68
TODO: - Migrate test utilities to generate Sapling-type Sprout proofs - Rename methods to include Sprout etc.
We aren't automatically deleting them yet.
It is in an anonymous namespace, so it needs to be above all code in the file that uses it.
Since nDefaultPort is always equal to ASSETCHAINS_P2PPORT and DNS records do not contain any information about the port number, the condition to check the correct port will always be true. Therefore, it can be removed.
7 tasks
Bakacje2019
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mini-gmpC-library has been removed, and the functionsbitcoin_base58{en,de}codehave been replaced with internal{En,De}codeBase58from the Bitcoin codebase.rewards CC; the same results can be achieved more efficiently using the internalarith_uint256type.payments CC; refactoring has been done to work with large numbers in calculations usingarith_uint256.Dilithiumandmusighave been removed from the CC in preparation for the upcoming update to thesecp256k1codebase.komododwill no longer verify old Sprout proofs and will assume they are valid. This change is safe forKMDand ACs, as transactions involving Sprout afterKOMODO_SAPLING_DEADLINE(February 15, 2019) were prohibited at the consensus level.libnsnarkandlibgmphave been removed from dependencies and build systems.These changes will result in faster Initial Block Download (IBD) due to saving CPU time on verifying old Sprout transactions and disabling scripts and other resource-intensive checks during IBD. Additionally, with the removal of old pre-sapling Sprout, the need for
sprout-proving.keyandsprout-verifying.keyfiles in.zcash-params(~910 Mb) is eliminated.