Skip to content

Commit

Permalink
feat: remove volume name
Browse files Browse the repository at this point in the history
  • Loading branch information
David-Crty committed Nov 9, 2024
1 parent adcf0f6 commit 7d5fda6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion helm-charts/generic-app/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v2
name: generic-app
description: A Helm Chart for Generic App
type: application
version: 0.3.11
version: 0.3.12
1 change: 0 additions & 1 deletion helm-charts/generic-app/templates/pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ spec:
{{- else }}
- ReadWriteOnce
{{- end }}
volumeName: {{ $fullName }}-{{ $volumeName }}
{{- if $volume.s3Driver }}
storageClassName: "" # required for static provisioning
resources:
Expand Down
3 changes: 0 additions & 3 deletions helm-charts/generic-app/tests/__snapshot__/pvc_test.yaml.snap
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ should have s3 driver volume mounts:
requests:
storage: 1200Gi
storageClassName: ""
volumeName: test-generic-app-public-files
should have s3 driver volume mounts with host cache:
1: |
apiVersion: v1
Expand Down Expand Up @@ -118,7 +117,6 @@ should have s3 driver volume mounts with host cache:
requests:
storage: 1200Gi
storageClassName: ""
volumeName: test-generic-app-public-files
should have volume mounts for data:
1: |
apiVersion: v1
Expand All @@ -138,4 +136,3 @@ should have volume mounts for data:
storage: 1Gi
storageClassName: ""
volumeMode: Filesystem
volumeName: test-generic-app-data

0 comments on commit 7d5fda6

Please sign in to comment.