RUM-7110 Add the OOB mobile view loading metrics properties #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
force-pushed
the
mconstantin/rum-7110/add-new-mobile-oob-view-loading-times-metrics
branch
3 times, most recently
from
b83dc02
to
ec7e7a6
Compare
ncreated
previously approved these changes
Nov 13, 2024
xgouchet
reviewed
Nov 13, 2024
schemas/rum/view-schema.json
Outdated
| @@ -31,6 +31,18 @@ | |||
| "minimum": 0, | |||
| "readOnly": true | |||
| }, | |||
| "network_settled_time": { | |||
| "type": "integer", | |||
| "description": "Duration in ns from the moment the initial network requests in current view started until they settled", | |||
There was a problem hiding this comment.
Note
IIRC from the RFC, the metric is measured from the moment the current view started, right, not from the start of the initial request?
Suggested change
| "description": "Duration in ns from the moment the initial network requests in current view started until they settled", | |
| "description": "Duration in ns from the moment the current view started until the initial network requests settled", |
There was a problem hiding this comment.
yes correct, my mistake here 👍
schemas/rum/view-schema.json
Outdated
| }, | ||
| "interaction_to_next_view_time": { | ||
| "type": "integer", | ||
| "description": "Duration in ns to from the last interaction on previous view to the moment the next view is displayed", |
There was a problem hiding this comment.
Note
The metric relates to the current view, not the next (future) one.
Suggested change
| "description": "Duration in ns to from the last interaction on previous view to the moment the next view is displayed", | |
| "description": "Duration in ns to from the last interaction on previous view to the moment the current view was displayed", |
There was a problem hiding this comment.
yeah...for me next is actually current in the context. But if you think current is better I can change it yes
mariusc83
force-pushed
the
mconstantin/rum-7110/add-new-mobile-oob-view-loading-times-metrics
branch
from
ec7e7a6
to
3d59884
Compare
xgouchet
approved these changes
Nov 13, 2024
joaooliveira-datadog
approved these changes
Nov 14, 2024
BenoitZugmeyer
approved these changes
Nov 14, 2024
| */ | ||
| readonly network_settled_time?: number; | ||
| /** | ||
| * Duration in ns to from the last interaction on previous view to the moment the current view was displayed |
There was a problem hiding this comment.
Suggested change
| * Duration in ns to from the last interaction on previous view to the moment the current view was displayed | |
| * Duration in ns from the last interaction on previous view to the moment the current view was displayed |
mariusc83
force-pushed
the
mconstantin/rum-7110/add-new-mobile-oob-view-loading-times-metrics
branch
from
3d59884
to
9907d32
Compare
mariusc83
deleted the
mconstantin/rum-7110/add-new-mobile-oob-view-loading-times-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our internal RFC we are adding 2 new properties on the
view-schema.jsonto be used for the out-of-the-box view loading time metrics we propose for the our mobile RUM sdks.