Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apiserver additionalconfig for cluster agent #1655

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c9952b2
add clusterAgent.apiserverCheck.additionalConfigs
aquiladayc Dec 31, 2024
c7a3eac
fix values.yaml
aquiladayc Dec 31, 2024
22f5f9f
fix values.yaml
aquiladayc Dec 31, 2024
5cca9d3
add clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus i…
aquiladayc Jan 7, 2025
19e2ef6
update readme
aquiladayc Jan 7, 2025
a76864d
update readme and blank default value
aquiladayc Jan 7, 2025
4e4ca80
Update charts/datadog/values.yaml
aquiladayc Jan 10, 2025
d97c548
Update charts/datadog/templates/_kubernetes_apiserver_config.yaml
aquiladayc Jan 10, 2025
4482176
Update charts/datadog/values.yaml
aquiladayc Jan 10, 2025
3c7d36b
update helper tpl
aquiladayc Jan 10, 2025
5826aee
update helper tpl
aquiladayc Jan 10, 2025
9019dfe
update deployment
aquiladayc Jan 10, 2025
d15a6c4
Merge branch 'main' into aquiladayc/apiserver-additionalconfig
aquiladayc Jan 10, 2025
e65094c
Update charts/datadog/values.yaml
aquiladayc Jan 14, 2025
eed6b48
Update charts/datadog/templates/_helpers.tpl
aquiladayc Jan 14, 2025
f6ad7ff
Update charts/datadog/templates/_kubernetes_apiserver_config.yaml
aquiladayc Jan 14, 2025
8f37639
Update charts/datadog/templates/cluster-agent-deployment.yaml
aquiladayc Jan 14, 2025
bd23134
update readme
aquiladayc Jan 14, 2025
f6cabbb
Merge branch 'main' into aquiladayc/apiserver-additionalconfig
aquiladayc Jan 14, 2025
c9371f4
Update charts/datadog/values.yaml
aquiladayc Jan 16, 2025
f845c69
Merge branch 'main' into aquiladayc/apiserver-additionalconfig
aquiladayc Jan 16, 2025
4f6025e
update readme and update version
aquiladayc Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/datadog/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Datadog changelog

## 3.89.0

* Add `clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus` to disable `use_component_status` option for kubernetes_apiserver check.

## 3.88.1

* Disable SBOM monitoring features for GKE Autopilot, as they are not supported
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: v1
name: datadog
version: 3.88.1
version: 3.89.0
appVersion: "7"
description: Datadog Agent
keywords:
Expand Down
3 changes: 2 additions & 1 deletion charts/datadog/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Datadog

![Version: 3.88.1](https://img.shields.io/badge/Version-3.88.1-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)
![Version: 3.89.0](https://img.shields.io/badge/Version-3.89.0-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)

[Datadog](https://www.datadoghq.com/) is a hosted infrastructure monitoring platform. This chart adds the Datadog Agent to all nodes in your cluster via a DaemonSet. It also optionally depends on the [kube-state-metrics chart](https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics). For more information about monitoring Kubernetes with Datadog, please refer to the [Datadog documentation website](https://docs.datadoghq.com/agent/basic_agent_usage/kubernetes/).

Expand Down Expand Up @@ -608,6 +608,7 @@ helm install <RELEASE_NAME> \
| clusterAgent.image.pullSecrets | list | `[]` | Cluster Agent repository pullSecret (ex: specify docker registry credentials) |
| clusterAgent.image.repository | string | `nil` | Override default registry + image.name for Cluster Agent |
| clusterAgent.image.tag | string | `"7.61.0"` | Cluster Agent image tag to use |
| clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus | bool | `false` | Set this to true to disable use_component_status for the kube_apiserver integration. |
| clusterAgent.livenessProbe | object | Every 15s / 6 KO / 1 OK | Override default Cluster Agent liveness probe settings |
| clusterAgent.metricsProvider.aggregator | string | `"avg"` | Define the aggregator the cluster agent will use to process the metrics. The options are (avg, min, max, sum) |
| clusterAgent.metricsProvider.createReaderRbac | bool | `true` | Create `external-metrics-reader` RBAC automatically (to allow HPA to read data from Cluster Agent) |
Expand Down
13 changes: 12 additions & 1 deletion charts/datadog/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,18 @@ Return Kubelet volumeMount
Return true if the Cluster Agent needs a confd configmap
*/}}
{{- define "need-cluster-agent-confd" -}}
{{- if (or (.Values.clusterAgent.confd) (.Values.datadog.kubeStateMetricsCore.enabled) (.Values.clusterAgent.advancedConfd) (.Values.datadog.helmCheck.enabled)) -}}
{{- if (or (.Values.clusterAgent.confd) (.Values.datadog.kubeStateMetricsCore.enabled) (.Values.clusterAgent.advancedConfd) (.Values.datadog.helmCheck.enabled) (.Values.datadog.collectEvents) (.Values.clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus)) -}}
true
{{- else -}}
false
{{- end -}}
{{- end -}}

{{/*
Return true if kubernetes_apiserver check should be configured
*/}}
{{- define "need-kubernetes-apiserver-check-config" -}}
{{- if or (.Values.datadog.collectEvents) (.Values.clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus) -}}
true
{{- else -}}
false
Expand Down
10 changes: 8 additions & 2 deletions charts/datadog/templates/_kubernetes_apiserver_config.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
{{- define "kubernetes_apiserver-config" -}}
{{- if .Values.datadog.collectEvents -}}
{{- if eq (include "need-kubernetes-apiserver-check-config" .) "true" }}
kubernetes_apiserver.yaml: |-
init_config:
instances:
- filtering_enabled: {{ .Values.datadog.kubernetesEvents.filteringEnabled }}
-
{{- if .Values.datadog.collectEvents }}
filtering_enabled: {{ .Values.datadog.kubernetesEvents.filteringEnabled }}
unbundle_events: {{ .Values.datadog.kubernetesEvents.unbundleEvents }}
{{- if .Values.datadog.kubernetesEvents.unbundleEvents }}
collected_event_types:
{{ .Values.datadog.kubernetesEvents.collectedEventTypes | toYaml | nindent 8 }}
{{- end -}}
{{- end }}
{{- if .Values.clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus }}
use_component_status: false
{{- end }}
{{- end -}}
{{- end -}}
2 changes: 1 addition & 1 deletion charts/datadog/templates/cluster-agent-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ spec:
- key: helm.yaml
path: helm.yaml
{{- end }}
{{- if .Values.datadog.collectEvents }}
{{- if eq (include "need-kubernetes-apiserver-check-config" .) "true" }}
- key: kubernetes_apiserver.yaml
path: kubernetes_apiserver.yaml
{{- end }}
Expand Down
5 changes: 5 additions & 0 deletions charts/datadog/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,11 @@ clusterAgent:
# username: datadog
# password: <YOUR_CHOSEN_PASSWORD>

## clusterAgent.kubernetesApiserverCheck -- correspond to options for configuring the kube_apiserver integration.
kubernetesApiserverCheck:
# clusterAgent.kubernetesApiserverCheck.disableUseComponentStatus -- Set this to true to disable use_component_status for the kube_apiserver integration.
disableUseComponentStatus: false

# clusterAgent.resources -- Datadog cluster-agent resource requests and limits.
resources: {}
# requests:
Expand Down
Loading