Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Fix ATR + DI issues with jest #5136

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Jan 20, 2025

What does this PR do?

  • Make the grace period apply only if the test has failed, not always.
  • Format the jest error always, not just with testing library errors, as the message is always in the stack in jest.

Motivation

  • Noticed some issues when dogfooding the feature.

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented Jan 20, 2025

Overall package size

Self size: 8.49 MB
Deduped: 94.84 MB
No deduping: 95.35 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-20 13:14:28

Comparing candidate commit 383dc3a in PR branch juan-fernandez/fix-di-atr-jest with baseline commit dcf3c7e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 909 metrics, 24 unstable metrics.

@juan-fernandez juan-fernandez marked this pull request as ready for review January 20, 2025 13:02
@juan-fernandez juan-fernandez requested review from a team as code owners January 20, 2025 13:02
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-di-atr-jest branch from 10ce515 to 383dc3a Compare January 20, 2025 13:03
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (307f471) to head (383dc3a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/plugins/util/test.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5136      +/-   ##
==========================================
+ Coverage   76.40%   76.73%   +0.32%     
==========================================
  Files          23      318     +295     
  Lines        1119    14511   +13392     
==========================================
+ Hits          855    11135   +10280     
- Misses        264     3376    +3112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juan-fernandez juan-fernandez merged commit 0d49ecf into master Jan 20, 2025
237 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-di-atr-jest branch January 20, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants