Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Ensure probe EMITTING status is sent correctly #5133

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Jan 19, 2025

What does this PR do?

Queue the probe EMITTING status before trying to queue the probe payload.

Motivation

Before, the EMITTING status was only emitted if the probe payload was successfully received by the agnet. If the agent didn't return a HTTP 2xx status code, the EMITTING status would never be sent.

Plugin Checklist

Additional Notes

@watson watson self-assigned this Jan 19, 2025
Copy link
Collaborator Author

watson commented Jan 19, 2025

Copy link

github-actions bot commented Jan 19, 2025

Overall package size

Self size: 8.48 MB
Deduped: 94.83 MB
No deduping: 95.35 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jan 19, 2025

Benchmarks

Benchmark execution time: 2025-01-19 18:04:08

Comparing candidate commit b12d02a in PR branch watson/fix-emitting with baseline commit 307f471 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 905 metrics, 26 unstable metrics.

scenario:debugger-line-probe-without-snapshot-18

  • 🟥 cpu_user_time [+37.327ms; +57.901ms] or [+5.590%; +8.671%]

scenario:startup-with-tracer-20

  • 🟥 cpu_user_time [+12.927ms; +22.104ms] or [+5.458%; +9.334%]

@watson watson force-pushed the watson/fix-emitting branch from f7cd309 to 2ebb959 Compare January 19, 2025 06:28
Base automatically changed from watson/fix-log-messages to master January 19, 2025 17:48
Queue the probe EMITTING status before trying to queue the probe
payload.

Before, the EMITTING status was only emitted if the probe payload was
successfully received by the agnet. If the agent didn't return a HTTP
2xx status code, the EMITTING status would never be sent.
@watson watson force-pushed the watson/fix-emitting branch from 2ebb959 to b12d02a Compare January 19, 2025 17:52
@watson watson marked this pull request as ready for review January 19, 2025 17:53
@watson watson requested review from a team as code owners January 19, 2025 17:53
@watson watson merged commit 34499f3 into master Jan 20, 2025
237 checks passed
@watson watson deleted the watson/fix-emitting branch January 20, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants