Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarir/remove inferred http route #5132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Zarir/remove inferred http route #5132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61f6683
remove inferred http route
zarirhamza Jan 19, 2025
f319d98
fix tests
zarirhamza Jan 19, 2025
06862fd
linter fixes
zarirhamza Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/dd-trace/src/plugins/util/inferred_proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ const log = require('../../log')
const tags = require('../../../../../ext/tags')

const RESOURCE_NAME = tags.RESOURCE_NAME
const HTTP_ROUTE = tags.HTTP_ROUTE
const SPAN_KIND = tags.SPAN_KIND
const SPAN_TYPE = tags.SPAN_TYPE
const HTTP_URL = tags.HTTP_URL
Expand Down Expand Up @@ -54,7 +53,6 @@ function createInferredProxySpan (headers, childOf, tracer, context) {
[SPAN_TYPE]: 'web',
[HTTP_METHOD]: proxyContext.method,
[HTTP_URL]: proxyContext.domainName + proxyContext.path,
[HTTP_ROUTE]: proxyContext.path,
stage: proxyContext.stage
}
}
Expand Down
2 changes: 0 additions & 2 deletions packages/dd-trace/test/plugins/util/inferred_proxy.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ describe('Inferred Proxy Spans', function () {
expect(spans[0].meta).to.have.property('http.url', 'example.com/test')
expect(spans[0].meta).to.have.property('http.method', 'GET')
expect(spans[0].meta).to.have.property('http.status_code', '200')
expect(spans[0].meta).to.have.property('http.route', '/test')
expect(spans[0].meta).to.have.property('span.kind', 'internal')
expect(spans[0].meta).to.have.property('component', 'aws-apigateway')
expect(spans[0].meta).to.have.property('_dd.inferred_span', '1')
Expand Down Expand Up @@ -130,7 +129,6 @@ describe('Inferred Proxy Spans', function () {
expect(spans[0].meta).to.have.property('http.url', 'example.com/test')
expect(spans[0].meta).to.have.property('http.method', 'GET')
expect(spans[0].meta).to.have.property('http.status_code', '500')
expect(spans[0].meta).to.have.property('http.route', '/test')
expect(spans[0].meta).to.have.property('span.kind', 'internal')
expect(spans[0].meta).to.have.property('component', 'aws-apigateway')
expect(spans[0].error).to.be.equal(1)
Expand Down
Loading