Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare patch version to support React Native SR #2458

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Dec 17, 2024

What does this PR do?

Cherrypicks the pr that exposes caches for React Native Session Replay image support and the fix for the cache miss issue.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos changed the title Prepare RN patch version 2.16.1 Prepare patch version to support React Native SR Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 83.95062% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.48%. Comparing base (0ecf62e) to head (fa8411d).
Report is 5 commits behind head on release/2.16.0.

Files with missing lines Patch % Lines
...m/datadog/android/internal/utils/ImageViewUtils.kt 0.00% 7 Missing ⚠️
...d/sessionreplay/recorder/mapper/ImageViewMapper.kt 57.14% 3 Missing ⚠️
...sessionreplay/internal/recorder/resources/Cache.kt 0.00% 2 Missing ⚠️
...internal/recorder/resources/BitmapCachesManager.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/2.16.0    #2458      +/-   ##
==================================================
- Coverage           69.92%   69.48%   -0.45%     
==================================================
  Files                 763      764       +1     
  Lines               28367    28450      +83     
  Branches             4763     4776      +13     
==================================================
- Hits                19835    19766      -69     
- Misses               7233     7377     +144     
- Partials             1299     1307       +8     
Files with missing lines Coverage Δ
.../java/com/datadog/android/internal/utils/IntExt.kt 0.00% <ø> (ø)
...java/com/datadog/android/internal/utils/LongExt.kt 0.00% <ø> (ø)
...ionreplay/material/internal/ChipWireframeMapper.kt 92.86% <100.00%> (+0.26%) ⬆️
.../sessionreplay/internal/DefaultRecorderProvider.kt 93.70% <100.00%> (+0.05%) ⬆️
...ssionreplay/internal/recorder/ViewUtilsInternal.kt 100.00% <ø> (ø)
...ternal/recorder/callback/RecorderWindowCallback.kt 91.95% <ø> (ø)
...eplay/internal/recorder/mapper/BasePickerMapper.kt 100.00% <ø> (ø)
...l/recorder/mapper/CheckableCompoundButtonMapper.kt 34.38% <ø> (-3.12%) ⬇️
...nternal/recorder/mapper/CheckableTextViewMapper.kt 62.07% <100.00%> (-1.09%) ⬇️
.../internal/recorder/mapper/CheckedTextViewMapper.kt 75.00% <ø> (ø)
... and 19 more

... and 30 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review December 18, 2024 10:38
@jonathanmos jonathanmos requested review from a team as code owners December 18, 2024 10:38
0xnm
0xnm previously approved these changes Dec 18, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jonathanmos jonathanmos merged commit 14b45a5 into release/2.16.0 Dec 18, 2024
24 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/prepare-rn-patch branch December 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants