[AN-257] Bump leo local mysql from 5.7 to 8.4 #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4806 +/- ##
===========================================
- Coverage 74.79% 74.77% -0.02%
===========================================
Files 165 165
Lines 14951 14954 +3
Branches 1187 1187
===========================================
Hits 11182 11182
- Misses 3769 3772 +3 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
lucymcnatt
reviewed
Dec 5, 2024
| @@ -1,6 +1,12 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <databaseChangeLog logicalFilePath="leonardo" xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.4.xsd"> | |||
| <changeSet logicalFilePath="leonardo" author="thibault" id="label"> | |||
| <validCheckSum>8:1d8581dc0977ea88b1f006f6bc00f5b9</validCheckSum> | |||
| <comment> | |||
| Mysql 8.4+ does not allow partial keys to be referenced for a foreign key anymore, see https://bugs.mysql.com/bug.php?id=114838. | |||
There was a problem hiding this comment.
thanks for the helpful comment here!
There was a problem hiding this comment.
An afternoon of frantic googling that I will never get back 😭
lucymcnatt
approved these changes
Dec 5, 2024
jgainerdewar
approved these changes
Dec 5, 2024
lucymcnatt
approved these changes
Dec 11, 2024
aednichols
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/AN-257
Summary of changes
What
restrict_fk_on_non_standard_keyto OFF because what we are doing has a very sensible business use case, and a lot of people are pushing back against MySQL decision to not support it, so we will see where this goes next.Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.