-
Notifications
You must be signed in to change notification settings - Fork 31
Monoid applicative tests #28
base: master
Are you sure you want to change the base?
Monoid applicative tests #28
Conversation
I just realized I'm a dingus and couldn't get the applicative tests to run becuase I never gave the functions a type constraint. |
We're good now |
Those tests for applicative laws are not valid. They use 1x1 matrices, but the size must be arbitrary (within a reasonable range). Also... Branch conflicts? I just accepted your other patch, so this is weird. |
The problem I was having was generating Arbitrary matricies of functions. I suppose I could write a custom instance |
Check |
In particular, if In other words: This gives you |
well that's a lot easier than what i was doing |
Yeah, you don't have to do anything. |
I'm getting a weird error where it's saying that (Int -> Int) isn't showable |
True... The argument of the property function you are testing must be instance of |
I went ahead and wrote a dummy instance of show for (Int->Int). This required turning on flexible instances in the testing source but it shouldn't be an issue since it's only test. We might want to constrain down the functions to a finite type (Bool -> Bool) then we could write actual instances for show for that type. |
This PR is downstream from #21 and #27