Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix be_visitor_map_cdr_op_ch #2151

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Fix be_visitor_map_cdr_op_ch #2151

merged 4 commits into from
Oct 26, 2023

Conversation

tmayoff
Copy link
Contributor

@tmayoff tmayoff commented Oct 25, 2023

#2141 (comment).

For these errors: https://tao.microfocus.com/scoreboard/rhel7_x64_dev/2023_10_24_20_44_Full.html#error_1. Does the generated c++ need to use typedefs rather than using?

Copy link
Member

@mitza-oci mitza-oci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(void) could be just () -- it's OK either way since existing code uses (void)

@mitza-oci
Copy link
Member

For these errors: https://tao.microfocus.com/scoreboard/rhel7_x64_dev/2023_10_24_20_44_Full.html#error_1. Does the generated c++ need to use typedefs rather than using?

Yes, looks like that compiler doesn't have C++11 type aliases.

@mitza-oci mitza-oci merged commit a8bfb31 into DOCGroup:ace6tao2 Oct 26, 2023
35 checks passed
@tmayoff tmayoff deleted the ace6tao2 branch October 26, 2023 15:32
@jwillemsen
Copy link
Member

Looks there are some more things left to cleanup

Error E2088 be_include\be_visitor_map/map_ch.h 33: Bad syntax for pure function definition
Error E2088 be_include\be_visitor_map/map_cs.h 35: Bad syntax for pure function definition
Error E2088 be_include\be_visitor_map/cdr_op_cs.h 32: Bad syntax for pure function definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants