Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: sizeof long double is different on ARM64 #2142

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

@mitza-oci mitza-oci requested review from jwillemsen and jrw972 October 5, 2023 19:44
Copy link
Member

@jwillemsen jwillemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I don't have a mac so can't test

@jwillemsen
Copy link
Member

@mitza-oci What about enabling Mergify (see https://docs.mergify.com/commands/backport) to simplify the backporting you have to perform?

@mitza-oci mitza-oci merged commit 1affc2b into DOCGroup:master Oct 6, 2023
41 checks passed
@mitza-oci mitza-oci deleted the macos-long-double branch October 6, 2023 13:34
mitza-oci added a commit to mitza-oci/ACE_TAO that referenced this pull request Oct 6, 2023
macOS: sizeof long double is different on ARM64
(cherry picked from commit 1affc2b)

# Conflicts:
#	ACE/ace/config-macosx-leopard.h
#	ACE/ace/config-macosx-tiger.h
@mitza-oci
Copy link
Member Author

@mitza-oci What about enabling Mergify (see https://docs.mergify.com/commands/backport) to simplify the backporting you have to perform?

We could try it. Merging only takes a minute though, unless there are conflicts.

@jwillemsen
Copy link
Member

@mitza-oci What about enabling Mergify (see https://docs.mergify.com/commands/backport) to simplify the backporting you have to perform?

We could try it. Merging only takes a minute though, unless there are conflicts.

I have enabled mergify for ACE/TAO and MPC, let us see if that helps. One of the easy things to use is that you can already give the backport command while the PR is being tested, when it is merged the backport PR is automatically created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants