Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features and fixes ar q2 q3 q4 2021 #858

Conversation

vahidm1993
Copy link
Contributor

@vahidm1993 vahidm1993 commented Dec 13, 2021

Summary of pull request to merge in new features developed at Agile Robots AG.

Open TODOs before the pr can be merged:

  • ...

Open TODOs after the pr:

  • release missing versions on pypi

vahidm1993 and others added 30 commits September 9, 2021 11:35
as the docker build host is still too slow
test: increase test timeout

See merge request dev/sys/tci/rafcon!17
as the treeview's model is now the TreeModelFilter the iters of the TreeModel can't be used directly for selecting elements;
the path can be used, as it is identical between the TreeModelFilter and the TreeModel
feat/add state machines search

See merge request dev/sys/tci/rafcon!16
…l-library-usages

# Conflicts:
#	CHANGELOG.rst
#	source/rafcon/gui/controllers/library_tree.py
add find usage feature

See merge request dev/sys/tci/rafcon!18
vahidm1993 and others added 24 commits October 29, 2021 13:40
new execution history layout

See merge request dev/sys/tci/rafcon!26
fix: API generation

See merge request dev/sys/tci/rafcon!28
…lop'

do not create already existing transitions

Closes DLR-RM#31

See merge request dev/sys/tci/rafcon!27
fix: assign an empty string to to_key_label

Closes DLR-RM#32

See merge request dev/sys/tci/rafcon!29
call 'show_notification' via 'idle_add'

Closes #41

See merge request dev/sys/tci/rafcon!33
Co-authored-by: Franz Steinmetz <[email protected]>
@sebastian-brunner
Copy link
Member

These changes already went through an internal review pipeline. We will also soon have another mr of this size.

The comments you gave for pr #857 were fixed in this pr.

@franzlst : could you have a look at it?

@franzlst
Copy link
Member

Thank you for these great features and important fixes. I focused on testing the new features and really like them. I found some possible improvements and bugs, which I list in the following:

  • The search in the tool bar is a cool feature. When the library tree is open, I can filter states. When I switch to the State Machine tree, the search icon is still visible and I would expect that I can use it to filter that tree just the same. However, it has no effect on the State Machine Tree. Therefore I suggest:
    • Either to to hide the icon when the Library Tree is not selected as tab
    • Or (preferably): Use the icon to search in the currently open widget
  • Finding usages of library in other libraries is awesome! In first expected that "Find usage" would show me usages of the library in the currently open state machine. Thus, I would suggest to change the label to "Find usages in libraries".
  • The better support of missing libraries is great, too. I created a library with several ports and added it to a state machine. After renaming it, it could no longer be found (of course) and was replaced by a dummy with proper size, all ports, and all ports connected. However, when using the substitute function to replace it with the renamed library, all connections went lost. That's a bit strange, because the substitute feature usually remains all connections if possible. Might this be a bug?
  • The possibility to rename and relocate libraries is also super helpful. Would have saved me a lot of time in the past :-D I found a bug here: When relocating a library that is stored in a library key that differs from the root folders name, the changed location points to the folder name instead of the root key name. Example: I have a folder named "agile-libs", which I insert with the library key "agile". When relocating a library (e.g. "dummy" to "dummynew") that is within this folder, state machines that contain the library are correctly identified, but instead of pointing to "agile/dummynew", they point to "agile-libs/dummynew".

@vahidm1993 vahidm1993 closed this Feb 20, 2022
@vahidm1993
Copy link
Contributor Author

A new pull request is created:

#861

@vahidm1993 vahidm1993 mentioned this pull request Feb 21, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants